fix: composesource object_size property should not call itself #1522
Conversation
…ively Signed-off-by: Tamas Kurics <[email protected]>
|
Not sure if excluding pylint C0103 is the way to go, but I have no better idea. |
Makefile
Outdated
| check: getdeps | ||
| @echo "Running checks" | ||
| @pylint --reports=no --score=no --disable=R0401,R0801 minio/*py minio/credentials tests/functional | ||
| @pylint --reports=no --score=no --disable=R0401,R0801,C0103 minio/*py minio/credentials tests/functional |
There was a problem hiding this comment.
You should not ignore the error.
There was a problem hiding this comment.
How should we handle it then? Currently pylint throws this error on the master branch.
tests/functional/tests.py:56:0: C0103: Variable name "_CLIENT" doesn't conform to '[a-z_][a-z0-9_]{2,30}$' pattern (invalid-name)
I could ignore this or the variable-rgx should be changed in the pylintrc file. I suppose this worked recently, otherwise it would not be on master. Maybe a pylint update causes it.
There was a problem hiding this comment.
Update: Pylint 3.3.9 works, 4.0.0 does not (released 12 Oct. 2025), so indeed a pylint update introduced this error.
There was a problem hiding this comment.
Refer #1521 how it is fixed
There was a problem hiding this comment.
Ok, so you already have a PR regarding this issue. Sorry, I have not checked it before. How should I proceed with this one?
- Shall I wait for your PR to be merged so after the merge I can rebase my branch to master.
- The other option is to convert those constants lowercase myself, basically repeating your work.
- The third one is the one that I suggested in my latest version: keep their names as is, since module-level constants look better in all-caps, but let
pylintignore those lines.
Signed-off-by: Tamas Kurics <[email protected]>
ghostrider77
force-pushed
the
fix-recursive-size
branch
from
d48dc96 to
11d131d
Compare
|
A better fix is #1524 |
2 participants
Combining data using server-side copy using
client.compose_object("bucket_name", "object_name", sources)does not work. The reason is that thecompose_objectmethod iteratively calls theobject_sizeproperty of eachComposeSourceobject and each of them recursively calls itself, resulting in aRecursionError.